Fix ECS resource detector bug #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhautikpip
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #569 +/- ##
=======================================
- Coverage 77.9% 77.9% -0.1%
=======================================
Files 55 55
Lines 2593 2594 +1
=======================================
Hits 2022 2022
- Misses 441 442 +1
Partials 130 130
|
|
Following the issue I've opened here, I went ahead and did a test with this implementation and it working very great for me on ECS with the following modifications ecsResourceDetector := ecs.ResourceDetector{Utils: new(ecs.DetectorUtils)}
ecsResource, err := ecsResourceDetector.Detect(ctx)
|
XSAM
requested changes
Feb 9, 2021
MrAlias
reviewed
Feb 9, 2021
|
@MrAlias addressed your comments! |
MrAlias
approved these changes
Feb 10, 2021
alolita
pushed a commit
to aws-otel/aws-otel.github.io
that referenced
this pull request
Feb 11, 2021
* Update go-sdk.mdx 1. Updated creation of OTEL exporter as per upstream `0.16.0` 2. Updated ECS and EKS resource detector initialization due to recent bug fix - open-telemetry/opentelemetry-go-contrib#569 open-telemetry/opentelemetry-go-contrib#575 However, we should wait for upstream to release `0.17.0` which will have these changes released. * Added `otelgrpc` dependency
Merged
6 tasks
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
This PR changes the circleci build config to build the project in both go-1.13 and go-1.14 versions. Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com> Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably now with the fix we can initialize resource detector as below:
Reference Issue: ECS resource detector crash aws-observability/aws-otel-go#16