-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelmongo: Use a mock deployment for testing against a MongoDB server #5749
Conversation
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test/opmsg_deployment.go
Outdated
Show resolved
Hide resolved
…y-go-contrib into otelmongo#39
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test/opmsg_deployment.go
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5749 +/- ##
=======================================
+ Coverage 65.8% 66.5% +0.7%
=======================================
Files 205 205
Lines 13097 13093 -4
=======================================
+ Hits 8618 8708 +90
+ Misses 4215 4118 -97
- Partials 264 267 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me, with the remaining question of the license.
I'll bring this topic to the SIG meeting later today.
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test/mongo_test.go
Outdated
Show resolved
Hide resolved
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test/mongo_test.go
Outdated
Show resolved
Hide resolved
…st/mongo_test.go Co-authored-by: Damien Mathieu <42@dmathieu.com>
…st/mongo_test.go Co-authored-by: Damien Mathieu <42@dmathieu.com>
We discussed the licensing issue during the SIG meeting on thursday, and I brought the question to the #otel-maintainers slack channel. What it seems other languages are doing is include both licenses, the original one as well as the OpenTelemetry one. Would having something similar work for you? |
@blink1073 @matthewdale Do you have thoughts on this? This PR proposes copying code from opmsg_deployment.go to mock a server for testing. The ask is that we include both our license as well as the OpenTelemetry license in that copy. Alternatively, we could use |
If possible, I'd recommend keeping the original LICENSE and adding a THIRD-PARTY-NOTICES file. |
Hi @dmathieu @pellared @MrAlias, @prestonvasquez has reworked the code to import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice.
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test/mongo_test.go
Outdated
Show resolved
Hide resolved
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test/mongo_test.go
Outdated
Show resolved
Hide resolved
…y-go-contrib into otelmongo#39
@pellared could you please take a look at Preston's latest changes? let us know if anything else is needed! |
@prestonvasquez, can you sync the branch with main? @open-telemetry/go-approvers, last call for review. I plan to merge this PR tomorrow unless nobody adds comments. |
…y-go-contrib into otelmongo#39
Resolves #39
Use mtest to mock a mongodb deployment.