Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure codespell failures fail CI #6064

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Sep 2, 2024

With the write option, codespell fixes issues (which is a nice behavior when we run it locally), but it also returns a 0 status code (except if some failures couldn't be fixed).

So in order to actually fix the CI on a failing codespell, we need to ensure the working directory is clean.

SDK counterpart: open-telemetry/opentelemetry-go#5761

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Sep 2, 2024
@dmathieu dmathieu changed the title Ensure the working directory is clean after running codespell Ensure codespell failures fail CI Sep 2, 2024
@dmathieu dmathieu added the Unlock Released Changelog PRs that need to change released section in CHANGELOG.md label Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.5%. Comparing base (b56f243) to head (45c22f1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6064     +/-   ##
=======================================
- Coverage   65.5%   65.5%   -0.1%     
=======================================
  Files        203     203             
  Lines      12985   12985             
=======================================
- Hits        8508    8506      -2     
- Misses      4218    4219      +1     
- Partials     259     260      +1     
Files with missing lines Coverage Δ
instrumentation/runtime/internal/x/x.go 100.0% <ø> (ø)

... and 1 file with indirect coverage changes

@dmathieu dmathieu marked this pull request as ready for review September 2, 2024 12:15
@dmathieu dmathieu requested a review from a team September 2, 2024 12:15
@dmathieu dmathieu merged commit 6ffea7b into open-telemetry:main Sep 3, 2024
26 checks passed
@dmathieu dmathieu deleted the codespell-failure branch September 3, 2024 15:43
@XSAM XSAM added this to the v1.30.0 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG Unlock Released Changelog PRs that need to change released section in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants