Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minsev to allow dynamic severities #6116

Merged
merged 15 commits into from
Sep 19, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 16, 2024

Similar to slog, allow the minsev.LogProcessor to be configured with dynamic severity resolution.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.8%. Comparing base (e1758b2) to head (b36db11).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6116   +/-   ##
=====================================
  Coverage   65.7%   65.8%           
=====================================
  Files        204     205    +1     
  Lines      13088   13097    +9     
=====================================
+ Hits        8610    8618    +8     
  Misses      4215    4215           
- Partials     263     264    +1     
Files with missing lines Coverage Δ
processors/minsev/minsev.go 92.0% <100.0%> (+5.6%) ⬆️
processors/minsev/severity.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias marked this pull request as ready for review September 16, 2024 19:36
@MrAlias MrAlias requested a review from a team September 16, 2024 19:36
pellared

This comment was marked as resolved.

pellared
pellared previously approved these changes Sep 17, 2024
processors/minsev/severity.go Show resolved Hide resolved
processors/minsev/example_test.go Outdated Show resolved Hide resolved
processors/minsev/minsev.go Show resolved Hide resolved
@pellared pellared dismissed their stale review September 17, 2024 08:57

Needs rebasing and addressing dmathieu comments

@MrAlias MrAlias requested a review from a team as a code owner September 19, 2024 14:37
@MrAlias MrAlias merged commit 2a72871 into open-telemetry:main Sep 19, 2024
27 checks passed
@MrAlias MrAlias deleted the minsev-dyn-sev branch September 19, 2024 17:51
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
MrAlias added a commit that referenced this pull request Oct 14, 2024
### Added

- The `Severitier` and `SeverityVar` types are added to
`go.opentelemetry.io/contrib/processors/minsev` allowing dynamic
configuration of the severity used by the `LogProcessor`. (#6116)
- Move examples from `go.opentelemetry.io/otel` to this repository under
`examples` directory. (#6158)
- Support yaml/json struct tags for generated code in
`go.opentelemetry.io/contrib/config`. (#5433)
- Add support for parsing YAML configuration via `ParseYAML` in
`go.opentelemetry.io/contrib/config`. (#5433)
- Add support for temporality preference configuration in
`go.opentelemetry.io/contrib/config`. (#5860)

### Changed

- The function signature of `NewLogProcessor` in
`go.opentelemetry.io/contrib/processors/minsev` has changed to accept
the added `Severitier` interface instead of a `log.Severity`. (#6116)
- Updated `go.opentelemetry.io/contrib/config` to use the
[v0.3.0](https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v0.3.0)
release of schema which includes backwards incompatible changes. (#6126)
- `NewSDK` in `go.opentelemetry.io/contrib/config` now returns a no-op
SDK if `disabled` is set to `true`. (#6185)
- The deprecated
`go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho`
package has found a Code Owner. The package is no longer deprecated.
(#6207)

### Fixed

- Possible nil dereference panic in
`go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace`.
(#5965)
- `logrus.Level` transformed to appropriate `log.Severity` in
`go.opentelemetry.io/contrib/bridges/otellogrus`. (#6191)

### Removed

- The `Minimum` field of the `LogProcessor` in
`go.opentelemetry.io/contrib/processors/minsev` is removed.
  Use `NewLogProcessor` to configure this setting. (#6116)
- The deprecated
`go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron`
package is removed. (#6186)
- The deprecated `go.opentelemetry.io/contrib/samplers/aws/xray` package
is removed. (#6187)

---------

Co-authored-by: David Ashpole <dashpole@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants