-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(otelhttp): unit tests #6151
Merged
pellared
merged 3 commits into
open-telemetry:main
from
knullism:refactor-otelhttp-transport-unit-test
Sep 25, 2024
Merged
refactor(otelhttp): unit tests #6151
pellared
merged 3 commits into
open-telemetry:main
from
knullism:refactor-otelhttp-transport-unit-test
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
added
the
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
label
Sep 24, 2024
dmathieu
approved these changes
Sep 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6151 +/- ##
=====================================
Coverage 66.8% 66.8%
=====================================
Files 206 206
Lines 13207 13207
=====================================
+ Hits 8827 8829 +2
+ Misses 4112 4111 -1
+ Partials 268 267 -1
|
I approved to run them earlier, but since you merged your branch with main, the approval was required again. |
pellared
approved these changes
Sep 24, 2024
dashpole
approved these changes
Sep 24, 2024
@5ylar, thank you for your contribution 🏅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small refactoring for
otelhttp transport
's unit tests to make them do the same way to createwrappedBody
instance.