Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(otelhttp): unit tests #6151

Merged

Conversation

knullism
Copy link
Contributor

This is just a small refactoring for otelhttp transport's unit tests to make them do the same way to create wrappedBody instance.

@knullism knullism requested review from dmathieu and a team as code owners September 24, 2024 03:55
Copy link

linux-foundation-easycla bot commented Sep 24, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.8%. Comparing base (ac19587) to head (76bfd1d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6151   +/-   ##
=====================================
  Coverage   66.8%   66.8%           
=====================================
  Files        206     206           
  Lines      13207   13207           
=====================================
+ Hits        8827    8829    +2     
+ Misses      4112    4111    -1     
+ Partials     268     267    -1     
Files with missing lines Coverage Δ
instrumentation/net/http/otelhttp/transport.go 95.2% <100.0%> (ø)

... and 1 file with indirect coverage changes

@knullism
Copy link
Contributor Author

Please check it out. It needs approval to run all of this.
image

@dmathieu
Copy link
Member

I approved to run them earlier, but since you merged your branch with main, the approval was required again.

@pellared
Copy link
Member

@5ylar, thank you for your contribution 🏅

@pellared pellared merged commit 5c74426 into open-telemetry:main Sep 25, 2024
25 checks passed
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants