Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oteslog: Improve transforming slog.KindAny attributes #6254

Merged
merged 6 commits into from
Oct 16, 2024
Merged

oteslog: Improve transforming slog.KindAny attributes #6254

merged 6 commits into from
Oct 16, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Oct 15, 2024 •
edited
Loading

Reuse convertValue in otelslog.

Follows #6237.

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.1%. Comparing base (3074e86) to head (f990508).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6254     +/-   ##
=======================================
+ Coverage   66.9%   67.1%   +0.2%     
=======================================
  Files        190     191      +1     
  Lines      12540   12621     +81     
=======================================
+ Hits        8395    8476     +81     
  Misses      3855    3855             
  Partials     290     290
Files with missing lines Coverage Δ
bridges/otellogrus/hook.go 97.5% <ø> (ø)
bridges/otelslog/convert.go 100.0% <100.0%> (ø)
bridges/otelslog/handler.go 96.4% <100.0%> (-0.1%) ⬇️
bridges/otelzap/core.go 97.2% <ø> (ø)

@pellared pellared changed the title Otelslog-complex-attrs oteslog: Improve transforming slog.KindAny attributes Oct 15, 2024
@pellared pellared added enhancement New feature or request bridge: slog Related to the slog bridge labels Oct 15, 2024
@pellared pellared marked this pull request as ready for review October 15, 2024 08:57
@pellared pellared requested review from a team, dmathieu and MrAlias as code owners October 15, 2024 08:57
@pellared pellared merged commit e1389ca into open-telemetry:main Oct 16, 2024
25 checks passed
@pellared pellared deleted the otelslog-complex-attrs branch October 16, 2024 05:49
@pellared pellared added this to the v1.32.0 milestone Oct 16, 2024
@pellared pellared mentioned this pull request Nov 8, 2024
Merged
pellared added a commit that referenced this pull request Nov 8, 2024
@pellared
Release v1.32.0/v0.57.0/v0.26.0/v0.12.0/v0.7.0/v0.5.0/v0.4.0 (#6311)
519f10d 
### Added

- Add the `WithSource` option to the
`go.opentelemetry.io/contrib/bridges/otelslog` log bridge to set the
`code.*` attributes in the log record that includes the source location
where the record was emitted. (#6253)
- Add `ContextWithStartTime` and `StartTimeFromContext` to
`go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`, which
allows setting the start time using go context. (#6137)
- Set the `code.*` attributes in
`go.opentelemetry.io/contrib/bridges/otelzap` if the `zap.Logger` was
created with the `AddCaller` or `AddStacktrace` option. (#6268)
- Add a `LogProcessor` to
`go.opentelemetry.io/contrib/processors/baggagecopy` to copy baggage
members to log records. (#6277)
  - Use `baggagecopy.NewLogProcessor` when configuring a Log Provider.
- `NewLogProcessor` accepts a `Filter` function type that selects which
baggage members are added to the log record.

### Changed 

- Transform raw (`slog.KindAny`) attribute values to matching
`log.Value` types.
For example, `[]string{"foo", "bar"}` attribute value is now transformed
to `log.SliceValue(log.StringValue("foo"), log.StringValue("bar"))`
instead of `log.String("[foo bar"])`. (#6254)
- Upgrade `go.opentelemetry.io/otel/semconv/v1.17.0` to
`go.opentelemetry.io/otel/semconv/v1.21.0` in
`go.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo`.
(#6272)
- Resource doesn't merge with defaults if a valid resource is configured
in `go.opentelemetry.io/contrib/config`. (#6289)

### Fixed

- Transform nil attribute values to `log.Value` zero value instead of
panicking in `go.opentelemetry.io/contrib/bridges/otellogrus`. (#6237)
- Transform nil attribute values to `log.Value` zero value instead of
panicking in `go.opentelemetry.io/contrib/bridges/otelzap`. (#6237)
- Transform nil attribute values to `log.Value` zero value instead of
`log.StringValue("<nil>")` in
`go.opentelemetry.io/contrib/bridges/otelslog`. (#6246)
- Fix `NewClientHandler` so that `rpc.client.request.*` metrics measure
requests instead of responses and `rpc.client.responses.*` metrics
measure responses instead of requests in
`go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`.
(#6250)
- Fix issue in `go.opentelemetry.io/contrib/config` causing
`otelprom.WithResourceAsConstantLabels` configuration to not be
respected. (#6260)
- `otel.Handle` is no longer called on a successful shutdown of the
Prometheus exporter in `go.opentelemetry.io/contrib/config`. (#6299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@dashpole dashpole dashpole approved these changes

@dmathieu dmathieu dmathieu approved these changes

Assignees
No one assigned
Labels
bridge: slog Related to the slog bridge enhancement New feature or request
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pellared @dmathieu @dashpole @MrAlias