Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically request reviews from codeowners of components #6282

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

dmathieu
Copy link
Member

We have more and more component owners who are not approvers/maintainers of the Go SIG, and are therefore not auto-assigned for review on opened PRs.

This GH Action is heavily inspired from the collector-contrib one:

For every open PR, it will loop through every code owner of the components that were updated in that PR, and request a review from them, unless they were the ones opening the PR or they already reviewed the PR.

@dmathieu dmathieu force-pushed the request-codeowners-review branch from 3f46850 to d2578cd Compare October 30, 2024 10:26
@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Oct 30, 2024
@dmathieu dmathieu force-pushed the request-codeowners-review branch from d2578cd to 6016ccd Compare October 30, 2024 10:27
@dmathieu dmathieu force-pushed the request-codeowners-review branch from 426e6d5 to 8bca49d Compare October 30, 2024 10:39
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.9%. Comparing base (c873ddc) to head (48b7690).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6282   +/-   ##
=====================================
  Coverage   66.9%   66.9%           
=====================================
  Files        193     193           
  Lines      15652   15652           
=====================================
+ Hits       10479   10482    +3     
+ Misses      4882    4880    -2     
+ Partials     291     290    -1     

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@dmathieu dmathieu force-pushed the request-codeowners-review branch 2 times, most recently from 8231707 to 8bca49d Compare October 30, 2024 11:14
@dmathieu
Copy link
Member Author

dmathieu commented Oct 30, 2024

This has been confirmed working on my fork.
dmathieu#1
https://github.com/dmathieu/opentelemetry-go-contrib/actions/runs/11592051616/job/32273102592?pr=1

The permissions allow modifying any PR. However, because we run on pull_request_target, changes made on a PR would not be looked into here, only the code on the main branch.
This should therefore not cause any security problem.

@dmathieu dmathieu marked this pull request as ready for review October 30, 2024 11:16
@dmathieu dmathieu requested a review from a team as a code owner October 30, 2024 11:16
@dmathieu
Copy link
Member Author

@open-telemetry/go-approvers for review

@dmathieu dmathieu merged commit 34774d4 into open-telemetry:main Nov 22, 2024
24 checks passed
@dmathieu dmathieu deleted the request-codeowners-review branch November 22, 2024 14:09
@MrAlias MrAlias added this to the v1.33.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants