Remove superfluous otelmongodb attribute names. Conform to specification. #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantorrie
requested review from
Aneurysm9,
dashpole,
jmacd,
MrAlias,
paivagustavo and
XSAM
as code owners
evantorrie
changed the title
MrAlias
reviewed
May 4, 2021
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/config.go
Outdated
Show resolved
Hide resolved
MrAlias
approved these changes
May 24, 2021
If the operation is a meta-level operation not involving a MongoDB collection, the spanName will default to the just the name of the operation. This conforms the otelmongodb instrumentation to the example provided in the OpenTelemetry specification.
Other language implementations do seem to include this. TODO: Better sanitization of the statement and and max. size limitation such as performed in the Java implementation
evantorrie
force-pushed
the
mongodb-attrs
branch
from
7ce17eb to
54f346d
Compare
|
@MrAlias This now looks ready to re-review again. No changes really from last time other than being rebased and having the integration tests fixed so that it's tested during the PR run. |
MrAlias
approved these changes
Aug 6, 2021
pellared
approved these changes
Aug 11, 2021
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
Integrate HTTP semantics helpers from contrib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #460
otelmongodbinstrumentation are removed and replaced with references tosemconvconventions from the mainopentelemetry-gorepository.<collection>.<operation>, or just<operation>if no collection is involved.