Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/Shopify/sarama from 1.28.0 to 1.29.0 in /instrumentation/github.com/Shopify/sarama/otelsarama/example #779

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 16, 2021

Bumps github.com/Shopify/sarama from 1.28.0 to 1.29.0.

Release notes

Sourced from github.com/Shopify/sarama's releases.

Version 1.29.0 (2021-05-07)

New Features / Improvements

Fixes

Changelog

Sourced from github.com/Shopify/sarama's changelog.

Changelog

Unreleased

Commits
  • 83d633e Merge pull request #1936 from Shopify/dnwe/follow-the-leader
  • 73be95a feat(test): add a unittest for leadership tracking
  • 8dbbfb5 Merge pull request #1917 from arkady-emelyanov/kip-554-scram-config-api
  • bb5205a Merge pull request #1934 from Shopify/dnwe/fv
  • 5108a1e fix(test): bump default KAFKA_VERSION to 2.7.1
  • 9d205e2 Merge pull request #1935 from Shopify/ref/heads/dnwe/improve-test
  • 66d5c44 Merge pull request #1933 from ozzieba/revert-removing-of-fork-for-asn1
  • 5e1dfc7 fix(test): improve flakey async producer test
  • ae85104 Merge pull request #1931 from Shopify/dnwe/golangci-lint
  • bbf1d62 Merge pull request #1930 from Shopify/dnwe/fix-balance-strategy-test
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/Shopify/sarama](https://github.com/Shopify/sarama) from 1.28.0 to 1.29.0.
- [Release notes](https://github.com/Shopify/sarama/releases)
- [Changelog](https://github.com/Shopify/sarama/blob/master/CHANGELOG.md)
- [Commits](IBM/sarama@v1.28.0...v1.29.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG labels May 16, 2021
….com/Shopify/sarama/otelsarama/example/github.com/Shopify/sarama-1.29.0
@evantorrie
Copy link
Contributor

This will only be fixed on 386 after IBM/sarama#1949 is merged, so I guess at best not until the next version of Shopify/sarama

Copy link
Contributor

@evantorrie evantorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close this until IBM/sarama#1949 is fixed.

@MrAlias MrAlias closed this Jun 14, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 14, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/instrumentation/github.com/Shopify/sarama/otelsarama/example/github.com/Shopify/sarama-1.29.0 branch June 14, 2021 15:33
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
* Rename plugin directory to instrumentation

As per open-telemetry/opentelemetry-specification#539

* Update package paths

* Fix tracer names in othttp instrumentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants