-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to using a skipper in the echo otel middleware #829
Added option to using a skipper in the echo otel middleware #829
Conversation
|
@pcairns I think you may need to rebase this to eliminate commit |
Codecov Report
@@ Coverage Diff @@
## main #829 +/- ##
=====================================
Coverage 75.4% 75.4%
=====================================
Files 69 69
Lines 3064 3071 +7
=====================================
+ Hits 2311 2318 +7
Misses 613 613
Partials 140 140
|
ad1634a
to
aea42e9
Compare
@Aneurysm9 sorry I've been away on vacation, this should be rebased now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one little comment to make the test(s) more trustworthy
other than that looks great 👍
I've updated the tests to include a check for the status code |
* Added option to using a skipper in the echo otel middleware * check status code in tests * fix option interface use Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Allow for a skipper (https://github.com/labstack/echo/blob/master/middleware/middleware.go#L15) to be passed into the echo middleware. The use case for this is we would like the ability to bypass tracing for certain routes (eg. health check endpoints).