Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelaws: Refactor option type #854

Merged
merged 2 commits into from
Jul 9, 2021
Merged

otelaws: Refactor option type #854

merged 2 commits into from
Jul 9, 2021

Conversation

pellared
Copy link
Member

@pellared pellared commented Jul 6, 2021

@pellared pellared mentioned this pull request Jul 6, 2021
Closed
@codecov
Copy link

codecov bot commented Jul 6, 2021 •
edited
Loading

Codecov Report

Merging #854 (01135f1) into main (28bd447) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #854   +/-   ##
=====================================
  Coverage   79.0%   79.0%           
=====================================
  Files         62      62           
  Lines       2726    2726           
=====================================
  Hits        2154    2154           
  Misses       440     440           
  Partials     132     132
Impacted Files Coverage Δ
...ion/github.com/aws/aws-sdk-go-v2/otelaws/config.go 100.0% <ø> (ø)
...tation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go 95.1% <100.0%> (ø)

@MrAlias MrAlias merged commit 4191fe4 into open-telemetry:main Jul 9, 2021
@pellared pellared deleted the otelaws-refactor-option branch July 9, 2021 21:26
garrettwegan referenced this pull request in garrettwegan/opentelemetry-go-contrib Jul 13, 2021
@pellared @MrAlias @garrettwegan
otelaws: Refactor option type (#854)
70616de 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
garrettwegan referenced this pull request in garrettwegan/opentelemetry-go-contrib Jul 22, 2021
@pellared @MrAlias @garrettwegan
otelaws: Refactor option type (#854)
497fc88 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@pellared pellared added this to the untracked milestone Nov 8, 2024
@MrAlias MrAlias mentioned this pull request Jun 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XSAM XSAM XSAM approved these changes

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.
3 participants
@pellared @MrAlias @XSAM