Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelkit: Refactor option type #858

Merged
merged 2 commits into from
Jul 20, 2021
Merged

otelkit: Refactor option type #858

merged 2 commits into from
Jul 20, 2021

Conversation

pellared
Copy link
Member

@pellared pellared commented Jul 7, 2021

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #858 (75cebb3) into main (01fdab7) will increase coverage by 0.7%.
The diff coverage is 85.6%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #858     +/-   ##
=======================================
+ Coverage   78.4%   79.1%   +0.7%     
=======================================
  Files         62      62             
  Lines       2737    2744      +7     
=======================================
+ Hits        2146    2172     +26     
+ Misses       456     440     -16     
+ Partials     135     132      -3     
Impacted Files Coverage Δ
detectors/gcp/gce.go 7.3% <0.0%> (ø)
detectors/gcp/gke.go 0.0% <0.0%> (ø)
exporters/metric/dogstatsd/internal/statsd/conn.go 59.2% <ø> (ø)
...github.com/aws/aws-sdk-go-v2/otelaws/attributes.go 100.0% <ø> (ø)
...ion/github.com/aws/aws-sdk-go-v2/otelaws/config.go 100.0% <ø> (ø)
...umentation/net/http/httptrace/otelhttptrace/api.go 100.0% <ø> (ø)
...on/net/http/httptrace/otelhttptrace/clienttrace.go 76.2% <ø> (ø)
instrumentation/net/http/otelhttp/labeler.go 84.6% <ø> (ø)
detectors/aws/eks/detector.go 32.7% <33.3%> (+3.6%) ⬆️
instrumentation/net/http/otelhttp/config.go 78.0% <77.7%> (ø)
... and 28 more

@MrAlias MrAlias merged commit 718a4aa into open-telemetry:main Jul 20, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants