Skip to content

Commit

Permalink
Remove the abandoned Process struct in Jaeger exporter (#1804)
Browse files Browse the repository at this point in the history
* Remove the abandoned Process struct in Jaeger exporter

Use of this struct was removed in #1776.

* Update changelog
  • Loading branch information
MrAlias authored Apr 13, 2021
1 parent 086abf3 commit 6db20e0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- The `HasRemoteParent` field of the `"go.opentelemetry.io/otel/sdk/trace".SamplingParameters` is removed.
This field is redundant to the information returned from the `Remote` method of the `SpanContext` held in the `ParentContext` field. (#1749)
- The `trace.FlagsDebug` and `trace.FlagsDeferred` constants have been removed and will be localized to the B3 propagator. (#1770)
- Remove `Process` configuration, `WithProcessFromEnv` and `ProcessFromEnv`, from the Jaeger exporter package.
The information that could be configured in the `Process` struct should be configured in a `Resource` instead. (#1776)
- Remove `Process` configuration, `WithProcessFromEnv` and `ProcessFromEnv`, and type from the Jaeger exporter package.
The information that could be configured in the `Process` struct should be configured in a `Resource` instead. (#1776, #1804)

## [0.19.0] - 2021-03-18

Expand Down
10 changes: 0 additions & 10 deletions exporters/trace/jaeger/jaeger.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,16 +175,6 @@ func InstallNewPipeline(endpointOption EndpointOption, opts ...Option) (func(),
return flushFn, nil
}

// Process contains the information exported to jaeger about the source
// of the trace data.
type Process struct {
// ServiceName is the Jaeger service name.
ServiceName string

// Tags are added to Jaeger Process exports
Tags []attribute.KeyValue
}

// Exporter is an implementation of an OTel SpanSyncer that uploads spans to
// Jaeger.
type Exporter struct {
Expand Down

0 comments on commit 6db20e0

Please sign in to comment.