Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for OTel Collector Attributes #1035

Closed
stefanprisca opened this issue Aug 5, 2020 · 1 comment · Fixed by #1062
Closed

Integration tests for OTel Collector Attributes #1035

stefanprisca opened this issue Aug 5, 2020 · 1 comment · Fixed by #1062
Labels
help wanted Extra attention is needed pkg:testing Related to testing or a testing package
Milestone
untracked

Comments

@stefanprisca
Copy link
Contributor

Existing integration tests for the OTel Collector (otel_integration_test) only cover integer attributes.
Maybe it would be interesting to create more use-cases for the attributes by testing the other types (string, bool, array, etc) as well.

The issue was brought up during PR #992 (comment) .
@MrAlias MrAlias added pkg:exporter pkg:testing Related to testing or a testing package help wanted Extra attention is needed labels Aug 5, 2020
@dengliming dengliming mentioned this issue Aug 15, 2020
Merged
@MrAlias
Copy link
Contributor

MrAlias commented Aug 20, 2020

resolved in #1062

@MrAlias MrAlias closed this as completed Aug 20, 2020
@MrAlias MrAlias linked a pull request Aug 20, 2020 that will close this issue
Integration tests for OTel Collector Attributes. #1062
Merged
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed pkg:testing Related to testing or a testing package
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Integration tests for OTel Collector Attributes. dengliming/opentelemetry-go
3 participants
@stefanprisca @pellared @MrAlias