Integration tests for OTel Collector Attributes. #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengliming
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
MrAlias
as code owners
Aneurysm9
approved these changes
Aug 16, 2020
|
Please add an entry in |
Aneurysm9
reviewed
Aug 16, 2020
MrAlias
reviewed
Aug 18, 2020
MrAlias
approved these changes
Aug 18, 2020
|
@dengliming I think this looks ready to merged. I tried syncing with upstream, but it looks like upstream changes need to be propagated into these changes. Specifically the migration of the |
|
@MrAlias Fixed. |
Merged
evantorrie
pushed a commit
to evantorrie/opentelemetry-go
that referenced
this pull request
Sep 10, 2020
* Integration tests for OTel Collector Attributes. * Update CHANGELOG.md * Fix review * Fix review. * Fix test. * Fix test. Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1035