Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for span processor ordering #1203

Closed
MrAlias opened this issue Sep 24, 2020 · 1 comment · Fixed by #1208
Closed

Add integration tests for span processor ordering #1203

MrAlias opened this issue Sep 24, 2020 · 1 comment · Fixed by #1208
Labels
area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package
Milestone
RC1

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Sep 24, 2020

Possibly, have two span processors be registered that each modified some state held by the test function. After a span was started and ended the state could be verified that it was updated in the correct order from the span processors.

Originally posted by @MrAlias in #1198 (comment)
@MrAlias MrAlias mentioned this issue Sep 24, 2020
Merged
@MrAlias MrAlias added area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package priority:p2 labels Sep 24, 2020
@MrAlias MrAlias added this to the RC1 milestone Sep 24, 2020
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 24, 2020

@huikang looks like you're not a member of the GitHub OpenTelemetry org yet (you should apply though 😄 ) so I can't directly assign this to you yet.

@huikang huikang mentioned this issue Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package
Projects
None yet
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

Add integration tests for span processor ordering huikang/opentelemetry-go
1 participant
@MrAlias