Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for span processor ordering #1208

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

huikang
Copy link
Member

@huikang huikang commented Sep 25, 2020

  • Test by span attributes added by processors in the order
    they were registered.

Resolves #1203

Signed-off-by: Hui Kang kangh@us.ibm.com

- Test by span attributes added by processors in the order
  they were registered.

Signed-off-by: Hui Kang <kangh@us.ibm.com>
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #1208 into master will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1208     +/-   ##
========================================
- Coverage    76.6%   76.6%   -0.1%     
========================================
  Files         134     134             
  Lines        5760    5760             
========================================
- Hits         4416    4414      -2     
- Misses       1102    1103      +1     
- Partials      242     243      +1     
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 78.4% <0.0%> (-2.2%) ⬇️

@MrAlias MrAlias merged commit a69f8fb into open-telemetry:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for span processor ordering
3 participants