-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not collect the histogram sum for UpDownCounter or ObservableGauge instruments #4161
Comments
This becomes much easier to address after #4304 Specifically because opentelemetry-go/sdk/metric/pipeline.go Lines 390 to 421 in 7f72e72
|
Currently the SDK does not allow for the explicit histogram aggregation to be used for up-down counters or gauges. Given the specification explicitly calls out the exception, it seems like this should instead be allowed. With the correct dropping of the sum when done. |
Any instrument that can record negative values, do not include a sum in the produced aggregation (like the specification recommends). Resolves open-telemetry#4161
* Allow histogram for all instruments Any instrument that can record negative values, do not include a sum in the produced aggregation (like the specification recommends). Resolves #4161 * Add changes to changelog * Fix TestBucketsSum
From the specification:
Proposal
Update our instrument aggregation selection code to introspect the instrument kind:
opentelemetry-go/sdk/metric/pipeline.go
Lines 423 to 428 in b907996
The text was updated successfully, but these errors were encountered: