Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Vendor Exporters #449

Closed
MrAlias opened this issue Jan 29, 2020 · 1 comment · Fixed by #452
Closed

Remove Vendor Exporters #449

MrAlias opened this issue Jan 29, 2020 · 1 comment · Fixed by #452
Milestone
Alpha v0.3 (Beta)

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jan 29, 2020

Vendors are expected to host their exporters external to this repository. The following vendor exporters should be removed

The dogstatsd exporter might need to just be renamed to statsd if there isn't any vendor specific logic present. Otherwise, it needs to be removed.
@MrAlias MrAlias mentioned this issue Jan 29, 2020
Closed
MrAlias referenced this issue in MrAlias/opentelemetry-go Jan 29, 2020
Remove the StackDriver trace exporter
cd19892 
Vendor exporters needed to be hosted outside this codebase.

Additionally, remove the http-stackdriver example.

Resolves #447

Partially addresses #449
@MrAlias MrAlias mentioned this issue Jan 29, 2020
Merged
@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 30, 2020

From gitter conversations the consensus is to leave the dogstatsd exporter.

it should be considered not a vendor-specific exporter, because it's widely supported outside of Datadog. E.g, the Veneur proxy accepts dogstatsd in and outputs in other formats.

@iredelmeier iredelmeier mentioned this issue Feb 4, 2020
Open
@rghetia rghetia added this to the Alpha v0.3 milestone Feb 13, 2020
rghetia added a commit that referenced this issue Mar 7, 2020
@MrAlias @rghetia
Remove the StackDriver trace exporter (#452)
9459629 
Vendor exporters needed to be hosted outside this codebase.

Additionally, remove the http-stackdriver example.

Resolves #447

Partially addresses #449

Co-authored-by: Rahul Patel <rahulpa@google.com>
MikeGoldsmith pushed a commit to MikeGoldsmith/opentelemetry-go that referenced this issue Mar 13, 2020
@MrAlias @rghetia @MikeGoldsmith
Remove the StackDriver trace exporter (open-telemetry#452)
d205fb6 
Vendor exporters needed to be hosted outside this codebase.

Additionally, remove the http-stackdriver example.

Resolves open-telemetry#447

Partially addresses open-telemetry#449

Co-authored-by: Rahul Patel <rahulpa@google.com>
@ymotongpoo ymotongpoo mentioned this issue Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Alpha v0.3 (Beta)
Development

Successfully merging a pull request may close this issue.

Remove the StackDriver trace exporter MrAlias/opentelemetry-go
2 participants
@MrAlias @rghetia