Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global tracers and meters should be identified also by SchemeURL #5403

Closed
pellared opened this issue May 22, 2024 · 0 comments · Fixed by #5426
Closed

global tracers and meters should be identified also by SchemeURL #5403

pellared opened this issue May 22, 2024 · 0 comments · Fixed by #5426
Assignees
Labels
area:metrics Part of OpenTelemetry Metrics area:trace Part of OpenTelemetry tracing bug Something isn't working pkg:API Related to an API package
Milestone

Comments

@pellared
Copy link
Member

pellared commented May 22, 2024

From https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#get-a-tracer:

Tracers are identified by name, version, and schema_url fields.

From https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#get-a-meter:

Meters are identified by name, version, and schema_url fields.

We are missing SchemeURL in the key:

type il struct {
name string
version string
}

Originally posted by @pellared in #5366 (comment)

@pellared pellared added pkg:API Related to an API package bug Something isn't working area:metrics Part of OpenTelemetry Metrics area:trace Part of OpenTelemetry tracing labels May 22, 2024
@MrAlias MrAlias self-assigned this May 28, 2024
@MrAlias MrAlias added this to the v1.28.0 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics area:trace Part of OpenTelemetry tracing bug Something isn't working pkg:API Related to an API package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants