Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use toolchain directive #5660

Closed
pellared opened this issue Jul 31, 2024 · 7 comments · Fixed by #5983
Closed

Do not use toolchain directive #5660

pellared opened this issue Jul 31, 2024 · 7 comments · Fixed by #5983
Assignees
@cheese-head
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v1.33.0

Comments

@pellared
Copy link
Member

pellared commented Jul 31, 2024 •
edited
Loading

I think that go 1.21.0 is required for the bump and it should not be a problem..

However, I do not think we need to add toolchain go1.22.5. I think it would be better to avoid toolchain consistently in all our Go modules.

Originally posted by @pellared in #5643 (comment)

We should have have some "linter" that would detect such changes.
@pellared pellared changed the title Remove toolchain directive Do not use toolchain directive Jul 31, 2024
@pellared pellared mentioned this issue Jul 31, 2024
Merged
@pellared pellared added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 1, 2024
pellared added a commit that referenced this issue Aug 1, 2024
@pellared
[chore] Remove toolchain from go.mod (#5661)
2726c6a 
Towards #5660
@pulin-dani
Copy link

is this already fixed and merged?

@pellared
Copy link
Member Author

pellared commented Aug 4, 2024

is this already fixed and merged?

From issue description:

We should have have some "linter" that would detect such changes

@MrAlias MrAlias mentioned this issue Aug 19, 2024
Merged
@MrAlias
Copy link
Contributor

MrAlias commented Aug 19, 2024

With the upgrade of Go to 1.23, the use of toolchain seems to be required: #5720 (comment)

@dmathieu
Copy link
Member

Closing this, as with Go 1.23, the toolchain directive is required and added automatically.

@dmathieu dmathieu closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
@pellared
Copy link
Member Author

pellared commented Sep 5, 2024

Closing this, as with Go 1.23, the toolchain directive is required and added automatically.

It is still not required. See: #5784

There are more people complaining on the go get and go mod tidy behavior so maybe eventually they will stop automatically adding the toolchain directive. See: golang/go#65847

@pellared pellared reopened this Sep 5, 2024
@bobrik

This comment was marked as off-topic.

Sign in to view
@bobrik bobrik mentioned this issue Oct 2, 2024
Closed
@MrAlias MrAlias added the contribfest Issue good for KubeCon contribfest label Nov 15, 2024
@cheese-head
Copy link
Contributor

I would like to work on this issue.

This was referenced Nov 16, 2024
Closed
Merged
@pellared pellared added this to the v1.33.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cheese-head cheese-head

Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging a pull request may close this issue.

Add toolchain check cheese-head/opentelemetry-go
6 participants
@dmathieu @bobrik @pellared @MrAlias @pulin-dani @cheese-head