Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental Instrument.Enabled SDK method #6002

Closed
mx-psi opened this issue Nov 25, 2024 · 0 comments · Fixed by #6016
Closed

Add experimental Instrument.Enabled SDK method #6002

mx-psi opened this issue Nov 25, 2024 · 0 comments · Fixed by #6016
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mx-psi
Copy link
Member

mx-psi commented Nov 25, 2024

Problem Statement

The Collector SIG is blocked on having Instrument.Enabled available on the OpenTelemetry Go libraries for stabilizing the component package (see open-telemetry/opentelemetry-collector/issues/11061).

Adding this to the API is blocked by open-telemetry/opentelemetry-specification/issues/4215, which is moving slowly. We would like to have it available at the SDK level instead.

Proposed Solution

We can use #5768 as a start and add this as an SDK-only, 'hidden' method:

Alternatives

Just wait.

Prior Art

We have both https://github.com/open-telemetry/opentelemetry-go/tree/main/sdk/metric/internal/x and https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/log/internal/x/README.md as prior examples of experimental methods/stuff.

Additional Context

Spoke about this with @pellared

@mx-psi mx-psi added the enhancement New feature or request label Nov 25, 2024
@pellared pellared added this to the v1.33.0 milestone Nov 26, 2024
codeboten added a commit to codeboten/opentelemetry-go that referenced this issue Dec 4, 2024
Opening this to get feedback on whether or not I'm headed in the right direction
based on the details listed in open-telemetry#6002. This
is a replacement for open-telemetry#5768

Fixes open-telemetry#6002

There are still some tests I would add, but overall I'm mostly looking to reviewers to let me know
if this is the correct approach (defining an interface in `x` and using that interface in the SDK)

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
dmathieu added a commit that referenced this issue Dec 6, 2024
#6016)

Fixes #6002

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Collector: v1 Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants