Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge HTTP instrumentation #974

Closed
5 tasks
MrAlias opened this issue Jul 27, 2020 · 5 comments
Closed
5 tasks

Merge HTTP instrumentation #974

MrAlias opened this issue Jul 27, 2020 · 5 comments
Assignees
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jul 27, 2020

The existing othttp and httptrace instrumentation need to be merged into a generalized instrumentation package to work with the standard library's net/http package.

@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 27, 2020

Relates to #940 (breaking into own module).

@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 28, 2020

It seems to follow that this should be moved to the contrib repository. We have opensource libraries as well as stdlib library instrumentation support there. It seems like a good idea to consolidate everything into a single location.

@Aneurysm9
Copy link
Member

I've created open-telemetry/opentelemetry-go-contrib#158 to relocate this instrumentation. The naming convention in contrib would lead me to think that the net/http and net/httptrace instrumentations should remain separate. Thoughts?

@Aneurysm9 Aneurysm9 self-assigned this Jul 28, 2020
@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 28, 2020

I've created open-telemetry/opentelemetry-go-contrib#158 to relocate this instrumentation. The naming convention in contrib would lead me to think that the net/http and net/httptrace instrumentations should remain separate. Thoughts?

The httptrace package in stdlib is a subpackage to net/http. Should we follow that structure as well? Not sure if there are implementation specific details that would prevent that structure, but it seems like it would be a decent approach to follow.

@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 6, 2020

closing in favor of open-telemetry/opentelemetry-go-contrib#158

@MrAlias MrAlias closed this as completed Aug 6, 2020
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants