Add instrumentation for net/http and net/httptrace #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eceaa35 as the change has not yet been published in a versioned module. Leaving the revert commit in history for ease of resurrection.
Aneurysm9
requested review from
evantorrie,
jmacd,
lizthegrey and
MrAlias
as code owners
lizthegrey
reviewed
Aug 5, 2020
MrAlias
approved these changes
Aug 5, 2020
|
@lizthegrey did your questions get answered or did we need to follow up on them? Wondering if I can merge this. |
jmacd
approved these changes
Aug 6, 2020
lizthegrey
approved these changes
Aug 6, 2020
Merged
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
othttpandhttptraceinstrumentations from the main repo, renaming them to conform to this repo's naming conventions. It also moves the HTTP example from the main repo and uses it to illustrate each instrumentation separately.Part of #158 and open-telemetry/opentelemetry-go#974