Add support for filtering metric label sets #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
evantorrie,
lizthegrey and
MrAlias
as code owners
Aneurysm9
suggested changes
Aug 11, 2020
Aneurysm9
approved these changes
Aug 11, 2020
MrAlias
reviewed
Aug 11, 2020
MrAlias
approved these changes
Aug 11, 2020
Thank you @MrAlias. Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Merged
evantorrie
pushed a commit
to evantorrie/opentelemetry-go
that referenced
this pull request
Sep 10, 2020
* Add support for filtering label sets * Restore test * Fix Value() bug * Pass kv.KeyValue * Apply suggestions from code review Thank you @MrAlias. Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
label.Set.Filter()method used to reduce label set dimensionality in a metric Processor. The Filter is afunc(string) boolthat includes labels when true and excludes labels when false.This was demonstrated in #1023, as being potentially useful in the Accumulator to avoid accumulation of synchronous instrument records by filtering at every metric event. Note that label filtering requires the fix in #1024 whether performed in the Accumulator or a Processor.
A companion PR #1048 adds a label set dimensionality-reducing Processor.