Move OTLP to the OTLP exporter #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To stop using the deprecated github.com/golang/protobuf and match what the collector is doing, switch to generating OTLP with the github.com/gogo/protobuf/proto instead of github.com/golang/protobuf/proto.
Remove all protobuf dependencies from otel package and all of its dependencies.
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd and
lizthegrey
as code owners
|
Working on resolving build issues. "Works on my machine" |
Remove submodule beforehand to avoid unneeded direct dependencies.
jmacd
approved these changes
Aug 10, 2020
Aneurysm9
approved these changes
Aug 11, 2020
Merged
evantorrie
pushed a commit
to evantorrie/opentelemetry-go
that referenced
this pull request
Sep 10, 2020
* Move proto to OTLP exporter * Update OTLP exporter import of proto * Use gogo protobuf To stop using the deprecated github.com/golang/protobuf and match what the collector is doing, switch to generating OTLP with the github.com/gogo/protobuf/proto instead of github.com/golang/protobuf/proto. * Clean dependencies Remove all protobuf dependencies from otel package and all of its dependencies. * Update CHANGELOG * Clean OTLP exporter go mod Remove submodule beforehand to avoid unneeded direct dependencies. * Use default ref for GitHub workflow * Update path that triggers proto gen action * Correct license-check exclusion for OTLP * Update commented location of the OTLP and code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated protobuf currently lives in the top level otel internal package. This mean that the API will always depend on a protobuf and grpc package. These are large dependencies that we are trying to remove to achieve our goal of having the API be a lightweight dependency for instrumentors (#940).
The only current use of this code is in the OTLP exporter. This moves all of this code to that exporter.
Additionally, the
github.com/golang/protobufpackage is deprecated: golang/protobuf#1104The docker container we use to generate the OTLP Go code is waiting on upstream changes before the alternate package will be used: namely/docker-protoc#177
For these reasons and to match what the collector is doing (https://github.com/open-telemetry/opentelemetry-collector/blob/master/Makefile#L260), I have switched to using "github.com/gogo/protobuf".
Resolves #1045