Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Callback Function. #1061

Merged
merged 3 commits into from
Aug 17, 2020
Merged

Rename Callback Function. #1061

merged 3 commits into from
Aug 17, 2020

Conversation

dengliming
Copy link
Member

for #966

Aneurysm9
Aneurysm9 approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to CHANGELOG.md noting the change in type names.

api/metric/async.go Outdated Show resolved Hide resolved
@Aneurysm9 Aneurysm9 merged commit 576a131 into open-telemetry:master Aug 17, 2020
@MrAlias MrAlias linked an issue Aug 20, 2020 that may be closed by this pull request
Unify Callback Function Naming #966
Closed
@MrAlias MrAlias mentioned this pull request Aug 20, 2020
Closed
@Aneurysm9 Aneurysm9 mentioned this pull request Aug 24, 2020
Merged
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantorrie evantorrie evantorrie approved these changes

@jmacd jmacd jmacd approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@MrAlias MrAlias Awaiting requested review from MrAlias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Unify Callback Function Naming
5 participants
@dengliming @Aneurysm9 @jmacd @evantorrie @pellared