Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend use of initializers for config structs #1163

Merged
merged 7 commits into from
Sep 11, 2020

Conversation

Aneurysm9
Copy link
Member

Updates style guide and changes existing configure() implementations to newConfig() as appropriate.

Updates style guide and changes existing configure() implementations to
newConfig() as appropriate.
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #1163 into master will increase coverage by 0.0%.
The diff coverage is 80.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1163   +/-   ##
======================================
  Coverage    77.9%   77.9%           
======================================
  Files         135     135           
  Lines        7191    7192    +1     
======================================
+ Hits         5602    5604    +2     
+ Misses       1346    1344    -2     
- Partials      243     244    +1     
Impacted Files Coverage Δ
exporters/otlp/options.go 51.7% <55.5%> (ø)
api/trace/tracetest/config.go 91.8% <100.0%> (ø)
api/trace/tracetest/provider.go 100.0% <100.0%> (ø)
exporters/otlp/otlp.go 79.3% <100.0%> (+0.1%) ⬆️
exporters/stdout/config.go 72.0% <100.0%> (ø)
exporters/stdout/exporter.go 26.6% <100.0%> (ø)
sdk/trace/batch_span_processor.go 79.5% <0.0%> (+1.0%) ⬆️

exporters/otlp/otlp.go Outdated Show resolved Hide resolved
@MrAlias MrAlias linked an issue Sep 10, 2020 that may be closed by this pull request
7 tasks
@XSAM
Copy link
Member

XSAM commented Sep 11, 2020

LGTM 🚀

@MrAlias MrAlias merged commit d91de43 into open-telemetry:master Sep 11, 2020
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Configuration Style Guide
4 participants