Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LastValue by default for ValueObserver instruments #1165

Merged
merged 21 commits into from
Sep 24, 2020

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Sep 11, 2020

The specification will state that ValueObserver uses LastValue aggregation by default. This includes adding OTLP Exporter support for LastValue aggregation.

Resolves #1139.

Part of #1177.

Corresponds with open-telemetry/opentelemetry-specification#984.

@jmacd jmacd marked this pull request as ready for review September 12, 2020 06:40
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #1165 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1165     +/-   ##
========================================
+ Coverage    76.4%   76.5%   +0.1%     
========================================
  Files         134     134             
  Lines        5732    5751     +19     
========================================
+ Hits         4384    4405     +21     
+ Misses       1105    1103      -2     
  Partials      243     243             
Impacted Files Coverage Δ
exporters/otlp/internal/transform/metric.go 87.3% <ø> (+3.5%) ⬆️
sdk/metric/selector/simple/simple.go 100.0% <ø> (ø)
sdk/trace/provider.go 92.9% <0.0%> (-3.5%) ⬇️
api/trace/api.go 57.1% <0.0%> (ø)
api/global/internal/trace.go 88.8% <0.0%> (ø)
api/trace/noop_trace_provider.go 100.0% <0.0%> (ø)
semconv/http.go 95.3% <0.0%> (+<0.1%) ⬆️

@jmacd
Copy link
Contributor Author

jmacd commented Sep 22, 2020

This corresponds with open-telemetry/opentelemetry-specification#984.

@Aneurysm9 Aneurysm9 merged commit 8c3cc43 into open-telemetry:master Sep 24, 2020
@MrAlias MrAlias mentioned this pull request Oct 1, 2020
2 tasks
@jmacd jmacd deleted the jmacd/lastvalue_observer branch June 18, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Prometheus Gauge in OpenTelemetry?
4 participants