Remove flaky BatchSpanProcessor.ForceFlush() test #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unreliable with no clear good way to make it reliable. The ForceFlush() method is a simple passthrough to bsp.exportSpans() and the existing tests of that method should suffice.
Aneurysm9
requested review from
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
MrAlias
approved these changes
Sep 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #1189 +/- ##
========================================
+ Coverage 76.9% 77.0% +0.1%
========================================
Files 135 135
Lines 5867 5867
========================================
+ Hits 4517 4523 +6
+ Misses 1109 1103 -6
Partials 241 241
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unreliable with no clear good way to make it reliable. The
ForceFlush() method is a simple passthrough to bsp.exportSpans() and the
existing tests of that method should suffice.