Set default propagator to no-op propagator #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huikang
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
|
@MrAlias , could you please help to take a look at this PR as I am not very sure if I am on the right direction. Thanks. |
huikang
force-pushed
the
1184-default-propagator
branch
2 times, most recently
from
6c51893
to
4c98ed0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
========================================
- Coverage 76.5% 76.5% -0.1%
========================================
Files 134 134
Lines 5806 5801 -5
========================================
- Hits 4443 4438 -5
Misses 1115 1115
Partials 248 248
|
Aneurysm9
reviewed
Sep 24, 2020
huikang
force-pushed
the
1184-default-propagator
branch
2 times, most recently
from
9303698
to
a413884
Compare
MrAlias
reviewed
Sep 28, 2020
huikang
force-pushed
the
1184-default-propagator
branch
from
a413884
to
3c3964c
Compare
jmacd
reviewed
Sep 29, 2020
huikang
force-pushed
the
1184-default-propagator
branch
from
b75abb9
to
bf9dccd
Compare
huikang
changed the title
MrAlias
approved these changes
Sep 29, 2020
Aneurysm9
approved these changes
Sep 29, 2020
- add set propagator to examples Signed-off-by: Hui Kang <kangh@us.ibm.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
huikang
force-pushed
the
1184-default-propagator
branch
from
bf9dccd
to
af1f8a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hui Kang kangh@us.ibm.com