Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(span): remove SetAttribute method #1216

Merged

Conversation

stanleynguyen
Copy link
Contributor

Resolves #1107

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 30, 2020

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #1216 into master will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1216   +/-   ##
======================================
  Coverage    76.5%   76.6%           
======================================
  Files         133     133           
  Lines        5795    5790    -5     
======================================
  Hits         4437    4437           
+ Misses       1109    1104    -5     
  Partials      249     249           
Impacted Files Coverage Δ
api/trace/api.go 57.1% <ø> (ø)
api/trace/noop_span.go 33.3% <ø> (ø)
api/trace/tracetest/mock_span.go 12.5% <ø> (ø)
api/trace/tracetest/span.go 97.3% <ø> (+1.2%) ⬆️
bridge/opentracing/internal/mock.go 71.0% <ø> (+0.6%) ⬆️
sdk/trace/span.go 93.1% <ø> (+1.4%) ⬆️
... and 2 more

CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias added area:trace Part of OpenTelemetry tracing pkg:API Related to an API package priority:p1 labels Sep 30, 2020
@MrAlias MrAlias added this to the RC1 milestone Sep 30, 2020
Revert markdown lint changes and unify the `Removed` section.
@MrAlias MrAlias merged commit de50711 into open-telemetry:master Oct 2, 2020
@Aneurysm9 Aneurysm9 mentioned this pull request Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing pkg:API Related to an API package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove API Span SetAttribute method
3 participants