-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move trace api package into otel
#1229
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1229 +/- ##
========================================
+ Coverage 76.6% 76.9% +0.2%
========================================
Files 133 130 -3
Lines 5754 5761 +7
========================================
+ Hits 4412 4433 +21
+ Misses 1093 1079 -14
Partials 249 249
|
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Includes resolutions for review issues.
This has broke https://github.com/go-redis/redis
|
It hasn't. Please ensure that you are using Go in module mode. That is the default in 1.14+, which is all that is currently supported by this project. When using Go in module mode the |
* Move trace API to otel * Move tracetest to oteltest * Update package documentation * Remove old api/trace package * Lint * Add changes to CHANGELOG * Add tests for rest of trace API * Apply suggestions from code review Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * Documentation fixes Includes resolutions for review issues. * Correct CHANGELOG post release Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Move the
api/trace
package into theotel
with the following changes:trace.ID
has been renamed tootel.TraceID
.trace.IDFromHex
has been renamed tootel.TraceIDFromHex
trace.EmptySpanContext
is removed to reduce the package contents and maintenance burden and the simplicity to duplicate the functionality it provided.ErrorOption
has been changed to an interface to conform with the project design guidelines which included adding aNewErrorConfig
function.The
api/trace/tracetest
package is moved tootel/oteltest
.Part of #964 and #1179