-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support exact kind in OTLP metrics exporter #1309
Conversation
@jmacd seen from the failed test, I noticed it's explicitly asserted this shuold not be supported https://github.com/open-telemetry/opentelemetry-go/blob/master/exporters/otlp/internal/transform/metric_test.go#L349 I'm not sure why is that, does this change makes sense at all? |
The change seems to make sense to me. If you configure the metrics telemetry pipeline to send exact values they should not error the exporter. The tests will need to be updated as part of this PR. opentelemetry-go/exporters/otlp/internal/transform/metric_test.go Lines 351 to 353 in 187adeb
|
Codecov Report
@@ Coverage Diff @@
## master #1309 +/- ##
======================================
Coverage 77.5% 77.5%
======================================
Files 125 125
Lines 6090 6131 +41
======================================
+ Hits 4720 4753 +33
- Misses 1119 1127 +8
Partials 251 251
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…nto transform-exact-kind
@MrAlias |
(Sorry all, I will catch up with this PR later today!!) |
To be explicit, it is sensible and correct to expose exact values as Gauge data points. |
I see a connection with open-telemetry/opentelemetry-proto#188. There's no way to know that the resulting Gauge data points represent raw data, but I would like there to be. |
Apologies, this appears to be tripped up by a change to package structure, likely #1321. |
…nto transform-exact-kind
…-go into transform-exact-kind
* support exact kind in OTLP metrics exporter * add change log * rename function * inline start time and end time variables * fix test * add test for exact int data points * add test for exact float data points * use newly introduced number package for numbers according to upstream change * fix package ref
When using
exactSelector
we found that the OTLP exporter does not handle array aggregator's kind (ExactKind
).This PR tries to fix it.