Metric Accumulator fix for SumObservers #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
evantorrie,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
========================================
+ Coverage 77.6% 78.0% +0.4%
========================================
Files 123 123
Lines 6131 6202 +71
========================================
+ Hits 4758 4838 +80
+ Misses 1122 1120 -2
+ Partials 251 244 -7
|
krnowak
reviewed
Dec 3, 2020
krnowak
approved these changes
Dec 3, 2020
krnowak
reviewed
Dec 3, 2020
|
@open-telemetry/go-approvers This is a HUGE bug, please approve. Fixes #1368. |
dashpole
approved these changes
Dec 10, 2020
Aneurysm9
approved these changes
Dec 10, 2020
jmacd
commented
Dec 10, 2020
MrAlias
approved these changes
Dec 11, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug makes the data from SumObserver and UpDownSumObserver instruments incorrect after the first collection. There were tests for the Processor behavior, which is relatively tricky, but not for the Accumulator. This adds a number of tests.
The means of fixing this is to let
SynchronizedMove(nil)mean "reset this accumulator" without allocations, which leads to simplifying the Accumulator.Fixes #1368