Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setting error status while recording error with Span from oteltest package #1729

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Remove setting error status while recording error with Span from oteltest package #1729

merged 3 commits into from
Mar 25, 2021

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Mar 25, 2021

Fix #1661. #1663 removes this behavior from trace.Span but leaves oteltest alone.

@MrAlias MrAlias merged commit 862a5a6 into open-telemetry:main Mar 25, 2021
@XSAM XSAM deleted the oteltest-record-error branch March 28, 2021 02:55
@XSAM XSAM mentioned this pull request Mar 28, 2021
Merged
@MrAlias MrAlias mentioned this pull request Apr 23, 2021
Merged
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Do not set error status when recording an error with RecordError
5 participants
@XSAM @Aneurysm9 @MadVikingGod @MrAlias @pellared