-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gRPC ClientConn for otlpmetricgrpc client connection handling #2425
Use gRPC ClientConn for otlpmetricgrpc client connection handling #2425
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2425 +/- ##
=======================================
+ Coverage 74.2% 75.5% +1.3%
=======================================
Files 175 175
Lines 12194 12170 -24
=======================================
+ Hits 9053 9199 +146
+ Misses 2904 2722 -182
- Partials 237 249 +12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
I might miss some contexts here, the implementation of go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc/client.go
looks similar to exporters/otlp/otlptrace/otlptracegrpc/client.go
. Any plan to merge these clients? so we do not change twice in the feature.
No, you didn't miss something and you are not alone (#2015). Ever since we refactored the OTLP exporters to be split by signal this duplication has existed. I think the next step now that this will bring the two signals in line is to unify and obscure common code in |
…lemetry-go into otlpmetricgrpc-clientconn
Follow up to #2329.
This updates the
otlpmetric
module:retry
internal package.otlpmetricgrpc
to use the gRPCClientConn
similar tootlptracegrpc
.retry
package in theotlpmetrichttp
client.