Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down golangci-lint config #2602

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 12, 2022

Disable all default linters prior to enabling the ones we want to ensure that no upgrade that include new default linters introduce changes to the CI system. This is effectively a no-op as it enables the exact linters that are already enabled.

Disable all default linters prior to enabling the ones we want to ensure
that no upgrade that include new default linters introduce changes to
the CI system.
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 12, 2022
@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #2602 (c6da45f) into main (1bda062) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2602   +/-   ##
=====================================
  Coverage   76.2%   76.2%           
=====================================
  Files        173     173           
  Lines      12238   12238           
=====================================
  Hits        9326    9326           
  Misses      2669    2669           
  Partials     243     243           
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 92.6% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 82.1% <0.0%> (+0.9%) ⬆️

@MadVikingGod MadVikingGod merged commit 25827f0 into open-telemetry:main Feb 14, 2022
@MrAlias MrAlias deleted the lock-golangci-lint-conf branch February 14, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants