Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded metrictest types #2864

Merged
merged 5 commits into from
Apr 27, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 26, 2022

The ExportRecord type introduced in #2776 duplicates the existing Batch and Measurment types. Remove the old types in favor of the added type.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #2864 (eb1f32b) into main (d342bde) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2864     +/-   ##
=======================================
- Coverage   75.7%   75.7%   -0.1%     
=======================================
  Files        180     179      -1     
  Lines      11818   11818             
=======================================
- Hits        8953    8951      -2     
- Misses      2632    2634      +2     
  Partials     233     233             
Impacted Files Coverage Δ
sdk/metric/metrictest/exporter.go 69.0% <100.0%> (+0.9%) ⬆️
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️

Copy link
Contributor

@MadVikingGod MadVikingGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you I completely missed those.

@MrAlias MrAlias added this to the Release v1.7.0 milestone Apr 26, 2022
@MrAlias MrAlias merged commit 776accd into open-telemetry:main Apr 27, 2022
@MrAlias MrAlias deleted the rm-dup-metrictest branch April 27, 2022 18:39
@MrAlias MrAlias mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants