-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve trace status handling #3214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdullaer
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
September 21, 2022 15:56
dmathieu
reviewed
Sep 21, 2022
This will require a changelog entry. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3214 +/- ##
=====================================
Coverage 77.3% 77.3%
=====================================
Files 159 159
Lines 11139 11142 +3
=====================================
+ Hits 8613 8620 +7
+ Misses 2329 2325 -4
Partials 197 197
|
wdullaer
force-pushed
the
fix-set-status
branch
3 times, most recently
from
September 21, 2022 16:53
38abca3
to
9d88b74
Compare
wdullaer
force-pushed
the
fix-set-status
branch
from
September 22, 2022 08:08
9d88b74
to
c4ba111
Compare
dmathieu
approved these changes
Sep 22, 2022
Aneurysm9
approved these changes
Sep 22, 2022
Aneurysm9
changed the title
Implement specification compliant trace status handling
Improve trace status handling
Sep 22, 2022
MrAlias
reviewed
Sep 22, 2022
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
wdullaer
force-pushed
the
fix-set-status
branch
from
September 23, 2022 08:50
2dcc2fc
to
3802c6d
Compare
MrAlias
approved these changes
Sep 23, 2022
This looks ready to merge once the lint issue is addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specification
SetStatus
should not allow overwriting the status if it has explicitly been set toOk
.From https://opentelemetry.io/docs/reference/specification/trace/api/#set-status
This is important for us, because the open telemetry middleware will explicit set an
Error
status for each nonOk
grpc status code, while not all of these status codes indicate an error in our application semantics. Because the middleware runs after our user code in the request flow, we have no way of explicitly marking such requests as Ok, even though the tracing specification clearly foresees it.