Improve test coverage, and don't send empty batches in OC bridge #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3263 +/- ##
=======================================
+ Coverage 77.4% 77.5% +0.1%
=======================================
Files 160 160
Lines 11200 11203 +3
=======================================
+ Hits 8673 8688 +15
+ Misses 2328 2315 -13
- Partials 199 200 +1
|
dmathieu
approved these changes
Oct 7, 2022
MadVikingGod
approved these changes
Oct 11, 2022
MrAlias
approved these changes
Oct 11, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of the changes from #3207. It adds tests, and doesn't send empty batches (which was the behavior in the previous opencensus bridge).