Removes the functionality of the Describe in prometheus exporter. #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3342 +/- ##
=====================================
Coverage 77.8% 77.8%
=====================================
Files 164 164
Lines 11269 11267 -2
=====================================
+ Hits 8768 8773 +5
+ Misses 2303 2297 -6
+ Partials 198 197 -1
|
dashpole
approved these changes
Oct 17, 2022
MrAlias
reviewed
Oct 17, 2022
MrAlias
added
bug
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe is called when a collector first registered with prometheus. The intent is for the collector to enumerate all metrics that it might emit in later collects. See the prometheus' Custom Collector Documentation
Because this happens before our SDK is started and because our SDK can dynamically add metrics we should always return no metrics in a Describe() making our collector "unchecked". This PR makes that the case always.
Note: I think this was always the behavior in the new SDK, I don't think there is a way currently to have an SDK that has started, had metrics created, and registered the reader before the collector was registered with prometheus.
Fixes: #3291