Disables context-as-argument linter #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently incompatible with viper v1.13.0. Status for the linter found at golangci/golangci-lint#3280
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
Aneurysm9
approved these changes
Oct 20, 2022
MrAlias
approved these changes
Oct 20, 2022
|
It doesn't need to. If you upgrade viper to v1.13.0, and have an old golangci it will still fail. |
MadVikingGod
added
the
Skip Changelog
|
link to #3372 |
hanyuancheung
approved these changes
Oct 21, 2022
|
This looks like it may not be needed. We upgraded to 1.50.1 of golangci-lint here and it no longer fails to run. |
|
It was pinned in 1.50.1, but we don't have it pinned in |
If that's the case and we want to move forward with this can you sync with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently incompatible with viper v1.13.0. Status for the linter found at golangci/golangci-lint#3280