-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redefine gauge in Prometheus example to be a Gauge #3498
Redefine gauge in Prometheus example to be a Gauge #3498
Conversation
UpDown counters are converted to prometheus gauges: https://github.com/open-telemetry/opentelemetry-go/blob/main/exporters/prometheus/exporter.go#L191. Since many OTel instruments (sync UpDownCounter, async Gauge, async UpDownCounter) all convert to prometheus gauges, this was trying to demonstrate the synchronous gauge case. We could change it to an async gauge if that makes it less confusing. |
SGTM. I'll make the change. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3498 +/- ##
=======================================
- Coverage 78.0% 78.0% -0.1%
=======================================
Files 165 165
Lines 11755 11755
=======================================
- Hits 9179 9177 -2
- Misses 2380 2382 +2
Partials 196 196
|
Fix #3493