Revert "Move global metric back to otel/metric/global for minor release (#3986)" #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ease (open-telemetry#3986)" This reverts commit 8dba38e.
MrAlias
added
pkg:API
MrAlias
changed the title
otel/metric (#3986)
MrAlias
changed the title
otel/metric (#3986)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4039 +/- ##
=====================================
Coverage 82.2% 82.2%
=====================================
Files 176 175 -1
Lines 13058 13058
=====================================
+ Hits 10736 10740 +4
+ Misses 2101 2097 -4
Partials 221 221
|
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dmathieu
approved these changes
May 2, 2023
Aneurysm9
approved these changes
May 2, 2023
felipe-lee
added a commit
to transcom/mymove
that referenced
this pull request
Jun 1, 2023
The only breaking change I saw was the removal of the `otel/metric/global` package. We instead need to use the base `otel` package, and the method names changed a bit: 1.16.0-rc.1 Relevant Notes: * The `go.opentelemetry.io/otel/metric/global` package is removed. Use `go.opentelemetry.io/otel` instead. [otel #4039](open-telemetry/opentelemetry-go#4039) * Support global `MeterProvider` in `go.opentelemetry.io/otel`. [otel #4039](open-telemetry/opentelemetry-go#4039) * Use `Meter` for a `metric.Meter` from the global `metric.MeterProvider`. * Use `GetMeterProivder` for a global `metric.MeterProvider`. * Use `SetMeterProivder` to set the global `metric.MeterProvider`. JIRA Ticket: MB-15974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8dba38e.
Resolves #4036