Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/resource: Fix build for BSD OSes #4077

Merged
merged 5 commits into from
May 10, 2023
Merged

Conversation

pellared
Copy link
Member

@pellared pellared commented May 9, 2023

Fixes #4076

Testing

~/repos/opentelemetry-go/sdk/resource$ GOOS=freebsd go build

@hacdias hacdias mentioned this pull request May 10, 2023
2 tasks
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #4077 (ec41de2) into main (0b61641) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4077   +/-   ##
=====================================
  Coverage   82.8%   82.8%           
=====================================
  Files        179     179           
  Lines      13498   13498           
=====================================
+ Hits       11178   11180    +2     
+ Misses      2099    2097    -2     
  Partials     221     221           
Impacted Files Coverage Δ
sdk/resource/host_id_readfile.go 0.0% <ø> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias merged commit 7dea222 into open-telemetry:main May 10, 2023
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request May 28, 2023
@pellared pellared deleted the fix-bsd branch November 17, 2023 09:01
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined: execCommand in host_id_bsd.go
4 participants