Metric SDK: Sum duplicate async observations regardless of filtering #4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4289 +/- ##
=======================================
- Coverage 83.5% 83.4% -0.1%
=======================================
Files 184 184
Lines 14365 14330 -35
=======================================
- Hits 11996 11957 -39
- Misses 2143 2147 +4
Partials 226 226
|
dashpole
commented
Jul 7, 2023
dashpole
force-pushed
the
simplify_filtered
branch
from
0f4df82
to
fdae38e
Compare
dashpole
changed the title
|
I'll wait to request review until I can rebase this on #4290 |
dashpole
force-pushed
the
simplify_filtered
branch
from
fdae38e
to
385c4d4
Compare
dashpole
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
|
Rebased, and ready for review! |
MrAlias
reviewed
Jul 13, 2023
MrAlias
approved these changes
Jul 13, 2023
pellared
approved these changes
Jul 14, 2023
dashpole
force-pushed
the
simplify_filtered
branch
from
56d3860
to
85e2d50
Compare
|
no worries. Rebased |
MrAlias
added
pkg:SDK
MadVikingGod
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4217
It addresses this issue by (always) summing duplicate observations regardless of whether or not a filter is applied. This simplifies the implementation as well by removing special code for the filtered vs non-filtered case.