Fix panic, deadlock and race in BatchSpanProcessor #4353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4249
Fixes #4335
Test result of
TestBatchSpanProcessorConcurrentSafe
test executed onmain
(without the fixes):As you can see
ForceFlush
was is not properly synchronized and there is a possible deadlock (sic!).Here is the test result (notice the test count is 100 times bigger) after the fixes are applied:
Here is the test result when I only cherry-pick 68e62aa on
main
(it contains a hotfix for the deadlock, but the race condition is still in place). It proves that the PR fixes #4249.It may be good to revisit the synchronization implementation, but I would rather do it as a separate PR. However, I think that current implementation is good enough for now. I created #4354