-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple otlp/otlptrace/otlptracegrpc
from otlp/internal
and otlp/otlptrace/internal
using gotmpl
#4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4400 +/- ##
=======================================
- Coverage 83.6% 83.5% -0.2%
=======================================
Files 196 206 +10
Lines 15306 15982 +676
=======================================
+ Hits 12811 13359 +548
- Misses 2237 2344 +107
- Partials 258 279 +21
|
MrAlias
force-pushed
the
gotmpl-otlptracegrpc
branch
from
August 2, 2023 19:35
e2f2058
to
2d29ed7
Compare
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
August 2, 2023 19:40
pellared
approved these changes
Aug 3, 2023
dashpole
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
otlp
exporters share internal packages across package boundaries. This is something we want to stop doing: #3846. This PR addresses the cross-module internal package use for theotel/exporters/otlp/otlptrace/otlptracegrpc
package.This is a follow up to #4397.