Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendered envconfig_test.go file name in otlpmetricgrpc #4419

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 7, 2023

from comment by @pellared in #4407 (comment)

@MrAlias MrAlias added bug Something isn't working Skip Changelog PRs that do not require a CHANGELOG.md entry pkg:exporter:otlp Related to the OTLP exporter package labels Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #4419 (ea1c859) into main (d1f33f1) will increase coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4419     +/-   ##
=======================================
+ Coverage   83.4%   83.5%   +0.1%     
=======================================
  Files        229     229             
  Lines      18645   18645             
=======================================
+ Hits       15551   15576     +25     
+ Misses      2775    2751     -24     
+ Partials     319     318      -1     

see 1 file with indirect coverage changes

@pellared
Copy link
Member

pellared commented Aug 7, 2023

Merging as this is a trivial fix.

@pellared pellared merged commit 196c1f0 into open-telemetry:main Aug 7, 2023
21 checks passed
@MrAlias MrAlias deleted the fix-rendered-name branch August 7, 2023 16:03
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:exporter:otlp Related to the OTLP exporter package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants